Feature | Reference Homepage redirect #708
Conversation
iati/custom_middleware.py
Outdated
|
|
||
| if domain == 'reference.iatistandard.org': |
There was a problem hiding this comment.
I think we want to check here for both domain and the path. Because I interpreted the ticket to only redirect reference.iatistandard.org and reference.iatistandard.org/ exclusively. I think catching this domain here would also redirect reference.iatistandard.org/anything-else which I don't think we want.
iati/custom_middleware.py
Outdated
| @@ -86,6 +90,8 @@ def redirected_url(self): | |||
| if self.stripped_path.startswith(self.wildcard_redirect_urls): | |||
| redirect_match = next(dict_value for dict_key, dict_value in settings.REFERENCE_NAMESPACE_WILDCARD_REDIRECT_DICT.items() if self.stripped_path.startswith(dict_key)) | |||
| self.stripped_path = self.remove_index_html(self.stripped_path) | |||
| print('wowowowowo') | |||
There was a problem hiding this comment.
Might have left debugging messages in the code here :)
iati/custom_middleware.py
Outdated
|
|
||
| if domain == 'reference.iatistandard.org' and parsed_url.path == '': |
There was a problem hiding this comment.
Testing this out with editing my /etc/hosts, and the parsed_url.path isn't blank:
web_1 | DOMAIN: reference.iatistandard.org
web_1 | PATH: /
Also to cover our bases, I think we should include the /en/ and /fr/ paths as some people may have cached redirects to those. And then lastly I wouldn't hardcode the /en/ in the redirect, and just redirect it to /iati-standard/. The locale redirects will direct the user to the correct /en/iati-standard or /fr/iati-standard based on their browser. So all together:
if domain == 'reference.iatistandard.org' and parsed_url.path in ['/', '/en/', '/fr/']:
return http.HttpResponsePermanentRedirect(f'{settings.REFERENCE_REDIRECT_BASE_URL}/iati-standard/')
Ticket #519